search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.91k stars 583 forks source link

pb2dict: fix flake8 error #2333

Closed rst0git closed 7 months ago

rst0git commented 8 months ago

This pull request updates the version of flake8 we use to run make lint in CI.

adrianreber commented 8 months ago

Why do we need a newer version? I am always in favour of distribution packages if possible.

rst0git commented 8 months ago

Why do we need a newer version?

I had the newer version of flake8 installed locally (via pip) and make lint was failing. The python3-flake8 package in Fedora Rawhide currently provides v6.0.0, which was released in November 2022. The most recent version (v7.0.0) was released about two weeks ago, but from the release notes, it looks like there aren't many changes.

I am always in favour of distribution packages if possible.

Should I drop the first patch?

rst0git commented 7 months ago

We discussed this with Adrian, and it looks like replacing flake8 with ruff would be a better option. I have updated the pull request to fix only the lint error, and I'll open another PR to replace flake8 with ruff.

rst0git commented 7 months ago

Closing in favour of https://github.com/checkpoint-restore/criu/pull/2346