search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.76k stars 560 forks source link

make: replace flake8 with ruff #2346

Closed rst0git closed 4 months ago

rst0git commented 4 months ago

This pull request is rebased on https://github.com/checkpoint-restore/criu/pull/2333 and https://github.com/checkpoint-restore/criu/pull/2345.

Ruff is a Python linter written in Rust, designed to replace flake8. It is significantly faster and actively maintained.

Snorch commented 4 months ago

I have no objections to switching flake8 -> ruff as far as it works =) It claims Drop-in parity with Flake8 so it should not be worse.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6d37f9a) 70.47% compared to head (c6d3796) 70.35%.

:exclamation: Current head c6d3796 differs from pull request most recent head 0bbfde1. Consider uploading reports for the commit 0bbfde1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2346 +/- ## ============================================ - Coverage 70.47% 70.35% -0.13% ============================================ Files 133 131 -2 Lines 33567 34251 +684 ============================================ + Hits 23658 24098 +440 - Misses 9909 10153 +244 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rst0git commented 4 months ago

@Snorch Thank you for the code review! Indeed, it seems that we only need to install Ruff for the lint workflow. I have updated the pull request.