search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.91k stars 583 forks source link

kerndat: check support for PAGE_IS_SOFT_DIRTY #2349

Closed rst0git closed 7 months ago

rst0git commented 7 months ago

The commit introducing PAGE_IS_SOFT_DIRTY has not been merged in kernel v6.7.x, and as a result, CRIU fails with the following error:

Error (criu/pagemap-cache.c:199): pagemap-cache: PAGEMAP_SCAN: Invalid argument'
Error (criu/pagemap-cache.c:225): pagemap-cache: Failed to fill cache for 63 (400000-402000)'

This patch updates check_pagemap() in kerndat to also check if PAGE_IS_SOFT_DIRTY is supported.

Fixes: #2334

codecov-commenter commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6d37f9a) 70.47% compared to head (037ff91) 70.54%.

:exclamation: Current head 037ff91 differs from pull request most recent head 424bb9c. Consider uploading reports for the commit 424bb9c to get more accurate results

Files Patch % Lines
criu/kerndat.c 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2349 +/- ## ============================================ + Coverage 70.47% 70.54% +0.06% ============================================ Files 133 133 Lines 33567 33636 +69 ============================================ + Hits 23658 23729 +71 + Misses 9909 9907 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.