CRIU package for Ubuntu 24.04

yang commented 4 months ago

I saw that criu was removed from the Ubuntu 24's apt repos - is there another easy package based way to install on Ubuntu, or is build chain the only way from here on? Thanks.

https://launchpad.net/ubuntu/noble/amd64/criu/3.17.1-3

https://launchpad.net/~criu/+archive/ubuntu/ppa (no noble releases)

mihalicyn commented 4 months ago

It's not removed from official Ubuntu repos, we just don't have PPA builds for Noble yet.

apt install criu should work just fine

Let me know if it does not work for you. I'll investigate this from Ubuntu side.

Upd: I have checked and can confirm problem. I'll try to figure out and come up with solution.

Thanks for reporting!

Upd 2: https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148

mihalicyn commented 4 months ago

rst0git commented 4 months ago

I will update the OBS/PPA packages with the workaround from https://github.com/checkpoint-restore/criu/issues/2398#issuecomment-2079198028 for the time being and enable support for Ubuntu 24.04.

mihalicyn commented 4 months ago

Huge thanks, Radostin!

I'll try to get CRIU into the official repos too. I was able to workaround compile-time failure, but there is another problem related to crit and python (see https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148).

rst0git commented 4 months ago

Please avoid running setup.py and easy_install.

@mihalicyn Should be fixed by https://github.com/checkpoint-restore/criu/pull/2282

In addition, we have also applied the following patch in https://github.com/rst0git/criu-deb-packages/commit/80ddb47974f541b99a7afc3e4e226e850648f27d

rst0git commented 4 months ago

@yang I can confirm that Ubuntu 24.04 support has been enabled for the packages in OBS and PPA:

mihalicyn commented 4 months ago

As I can see from https://launchpad.net/~criu/+archive/ubuntu/ppa/+packages we have no builds for Noble, but only for Jammy. I guess we need to change the last entry in debian/changelog file and specify noble in there.

I'm currently stuggling with this install-stage failure during binary package build: https://launchpadlibrarian.net/730947573/buildlog_ubuntu-noble-amd64.criu_3.17.1-3ubuntu1_BUILDING.txt.gz

I have applied these patches: https://github.com/checkpoint-restore/criu/commit/7f0f07599a680258092a7790fb3046856f486f2f https://github.com/rst0git/criu-deb-packages/commit/80ddb47974f541b99a7afc3e4e226e850648f27d

but it looks like we need something in addition to make it work on Noble. Will continue investigation.

rst0git commented 4 months ago

@mihalicyn Thanks for pointing this out! I've updated the release to noble in launchpad.

but it looks like we need something in addition to make it work on Noble. Will continue investigation.

dh_usrlocal: error: debian/criu/usr/local/bin/crit is not a directory
make: *** [debian/rules:9: binary] Error 25

There is a bug in the version of pip available on Ubuntu since 22.04. The pip install command does not take into account the value specified with --prefix when installing scripts (i.e., crit). This problem does not exist in earlier versions and it has fixed in newer versions of pip. As a workaround for this problem we use the following patch: https://github.com/rst0git/criu-deb-packages/commit/e025b7edc7a1d6454048e337f774748de846cdf0

mihalicyn commented 4 months ago

Thanks @rst0git!

I have prepared a new debdiff: https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148/comments/5

hope it will be sponsored and uploaded. It is usually hard to get stable release packages updated.