search

checkstyle / contribution

some useful sources that should not stay in main repo but it is good to host them
GNU Lesser General Public License v2.1
49 stars 131 forks source link

Refactoring of diff.groovy #182

Open MEZk opened 7 years ago

MEZk commented 7 years ago

1) generateDiffReport and generateCheckstyleReport now receive too many parameters. Parameters should be represented as an objects of the specific class or the methods need to be refactored so as not to have so many parameters.

romani commented 7 years ago

to my mind is it fine to have that much arguments for now.

Parameters should be represented as an objects

please do not over complicate the problem. All arguments could be refactored to single structure/object as wrapper.

MEZk commented 7 years ago

should be done after #213