search

checkstyle / contribution

some useful sources that should not stay in main repo but it is good to host them
GNU Lesser General Public License v2.1
49 stars 130 forks source link

Update project commit id's in checkstyle-tester project files #590

Closed nrmancuso closed 2 years ago

nrmancuso commented 2 years ago

Noticed at https://github.com/checkstyle/checkstyle/pull/11100, many commit id's that use release versions (such as PMD, orekit, and others) need to be updated to use the newest release versions. This will require testing of each project. The easiest way to do this is to:

  1. update each project to latest release commit, send PR to contribution
  2. open a dummy PR in checkstyle main repo where most of these projects files are used, and replace cloned contribution repo to PR branch.
  3. Make sure that all CI pass
  4. In the case of projects-to-test-on.properties, we can use this projects file with github report generation action to show successful update
rnveach commented 2 years ago

Some commits are old because they had coding a specific way and then did an upgrade and like revamped their changes. Some are because they fail to keep project no-violation free.

romani commented 2 years ago

yes, we need to update this "release" commits from time to time. All of them are done to make CI stable, as not all projects use CI and enforce build status on each commit.

nrmancuso commented 2 years ago

Duplicate of https://github.com/checkstyle/contribution/issues/250