checkstyle / contribution

some useful sources that should not stay in main repo but it is good to host them
GNU Lesser General Public License v2.1
49 stars 130 forks source link

Update checkstyle/jdk-11-groovy-git-mvn to use latest version of maven, git, and groovy #763

Closed Vyom-Yadav closed 11 months ago

Vyom-Yadav commented 1 year ago

We aim to run groovy scripts in a docker container to utilize the latest groovy version. Main repo issue: https://github.com/checkstyle/checkstyle/issues/12646

File to be updated:

devops/docker/no-exception-build-image/jdk-11-groovy-git-mvn/Dockerfile

Shubhamrajgithub commented 1 year ago

Hi @Vyom-Yadav is this issue still live ?

Vyom-Yadav commented 1 year ago

Yes

On Sat, 11 Mar 2023, 11:41 pm Shubham Raj, @.***> wrote:

Hi @Vyom-Yadav https://github.com/Vyom-Yadav is this issue still live ?

— Reply to this email directly, view it on GitHub https://github.com/checkstyle/contribution/issues/763#issuecomment-1464969998, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTVXPK3CKANIR7ETC3JMK3W3S55LANCNFSM6AAAAAAT777X7Y . You are receiving this because you were mentioned.Message ID: @.***>

Shubhamrajgithub commented 1 year ago

@Vyom-Yadav Can you guide me about this issue and what actually to work on.

Vyom-Yadav commented 1 year ago

You need to update https://github.com/checkstyle/contribution/blob/master/devops/docker/maven-build-image/jdk-8u162b12/Dockerfile to use the latest version of maven, git, and groovy.

Shubhamrajgithub commented 1 year ago

@Vyom-Yadav I have tried to update the packages in the above file, can you check that if it works.

Vyom-Yadav commented 1 year ago

@Shubhamrajgithub You need to create a pull request.

romani commented 11 months ago

Did we addressed this issue in your latest container?

We did not updated groovy to latest , and we actually downgraded to older version , details at https://github.com/checkstyle/contribution/pull/810#issuecomment-1813724673

From that issue:

looks like we went to older version of groovy due to Ubuntu usage.

@nrmancuso , @relentless-pursuit, can you explain a bit more?

https://github.com/checkstyle/contribution/commit/f059eb492b3ac9d94eaae39c69b55e17c57f9da6#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R54 we downgraded 3.0.9 to 2.4.21

nrmancuso commented 11 months ago

Since we are using Ubuntu, it was easier to use the version of groovy that is included; we needed to unblock maven version update in main repo. We can do a separate battle with custom groovy version in scope of this issue. We can do manual installation, or try to layer docker images if that is easier and doesn’t bloat the image.

romani commented 11 months ago

https://circleci.com/developer/images/image/cimg/base

Software: build-essential 12.9ubuntu3, curl 7.81.0, docker 24.0.6, docker-compose /usr/local/bin/docker-compose Docker Compose version v2.23.0 v2.23.0, dockerize v0.8.0, git 2.42.0, jq 1.6, ubuntu 22.04.3 LTS, wget 1.21.2

Looks like they stick with Ubuntu 22, lts.

Vyom-Yadav commented 11 months ago

I don't understand why we don't use official groovy image as base and just install maven on those? Won't that sort our problem?

romani commented 11 months ago

We do not need latest groovy for sure :).

Vyom-Yadav commented 11 months ago

Let's close this issue then.