search

checkstyle / patch-filters

Suppression Filter for Checkstyle that is based on patch file
GNU Lesser General Public License v2.1
4 stars 6 forks source link

List checks that will miss some violations when only use supportContextStrategyChecks property #308

Closed HuGanghui closed 4 years ago

HuGanghui commented 4 years ago

List checks that will miss some violations when only use supportContextStrategyChecks property

rdiachenko commented 4 years ago

@HuGanghui please clarify the description and what you are trying to achieve by this issue? The PR is in a draft stage, any reason?

HuGanghui commented 4 years ago

@rdiachenko because some checks listed in https://github.com/checkstyle/patch-filters/issues/8 need use neverSuppressedChecks or checkNameForContextStrategyByTokenOrParentSet, otherwise they will suppress some violations that should not be suppressed.

Draft status is that I want to merge #303 first, then review this PR.

rdiachenko commented 4 years ago

The fix was merged.