search

checkstyle / patch-filters

Suppression Filter for Checkstyle that is based on patch file
GNU Lesser General Public License v2.1
4 stars 6 forks source link

Rename SuppressionPatchXpathFilter to SuppressionJavaPatchFilter #312

Closed rdiachenko closed 4 years ago

rdiachenko commented 4 years ago

SuppressionPatchXpathFilter is not related to xpath. Please rename it to SuppressionJavaPatchFilter. Also, update all patchxpath usages with javapatch. There should not be any xpath words in the project.

romani commented 4 years ago

leftovers 

✔ ~/java/github/checkstyle/patch-filters [HuGanghui/java-patch L|✔]
$ ag "xpath"
README.md
43:### SuppressionPatchXpathFilter
45:Filter SuppressionPatchXpathFilter(TreeWalker level) has three different strategies that control suppression
75:For example, the following configuration fragment directs the Checker to use a SuppressionPatchXpathFilter 
84:the following configuration fragment directs the Checker to use a SuppressionPatchXpathFilter 
93:the following configuration fragment direts the Checker to use a SuppressionPatchXpathFilter 

config/checkstyle.properties
2:checkstyle.suppressions-xpath.file=config/suppressions.xml

@HuGanghui , please fix them also. there should be no xpath word at all in repo

romani commented 4 years ago

@HuGanghui , please rebase all other PRs and rename in them also.

HuGanghui commented 4 years ago

@romani ok, but in config/checkstyle.properties 2:checkstyle.suppressions-xpath.file=config/suppressions.xml , this xpath is a fixed config, not introduced by this repo.

rdiachenko commented 4 years ago

The rest of the renaming was done in https://github.com/checkstyle/patch-filters/pull/314 and merged.