search

checkstyle / patch-filters

Suppression Filter for Checkstyle that is based on patch file
GNU Lesser General Public License v2.1
4 stars 6 forks source link

config: upgrade tests to jupiter and drop junit 4 #353

Closed rnveach closed 2 years ago

rnveach commented 2 years ago

Upgrading as I couldn't run tests in Eclipse on the project without downgrading JUnit runner. My tests are still failing, so I can't validate this change locally.

rnveach commented 2 years ago

Master: https://github.com/checkstyle/patch-filters/actions/runs/3446645759/jobs/5751807354#step:4:8454

Tests run: 120, Failures: 0, Errors: 0, Skipped: 0

PR: https://github.com/checkstyle/patch-filters/actions/runs/3455959136/jobs/5768347631#step:4:8326

Tests run: 119, Failures: 0, Errors: 0, Skipped: 0

GeneratePatchFileTest did not run, but it is an empty test anyways. I guess jupiter has some awareness of this?