search

checkstyle / patch-filters

Suppression Filter for Checkstyle that is based on patch file
GNU Lesser General Public License v2.1
4 stars 7 forks source link

allows to catch jgit exceptions in suppression filters #357

Closed rnveach closed 1 year ago

rnveach commented 1 year ago

Similar to https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/Checker.java#L298-L300

When JGit fails, it doesn't throw an IOException (atleast not all the time). I was getting custom exceptions that extend IllegalArguments like when the \r was still in the file. When it happened it skipped displaying our chain of the exception. This will ensure we get our message in.

romani commented 1 year ago

CI is not happy https://github.com/checkstyle/patch-filters/actions/runs/3457633245/jobs/5771250625#step:5:75

rnveach commented 1 year ago

Done.