search

checkstyle / patch-filters

Suppression Filter for Checkstyle that is based on patch file
GNU Lesser General Public License v2.1
4 stars 6 forks source link

Missing Generate Patch Tests #360

Open rnveach opened 1 year ago

rnveach commented 1 year ago

Identified at https://github.com/checkstyle/patch-filters/blob/master/src/test/java/com/github/checkstyle/generatepatchfile/GeneratePatchFileTest.java#L26 ,

The test class has no tests inside. Everything inside com.github.checkstyle.generatepatchfile is uncovered.

Tests should be added for this package to cover functionality.

romani commented 1 year ago

It is because we abandoned generation and rely on smart outside tools to make it.

rnveach commented 1 year ago

Then should we remove code completely?

romani commented 1 year ago

Let's keep it for now, as we never finished testing on real project for long period to be sure our idea was correct. As we already see patches on different OS looks a bit different.

But we can remove test file for sure.