search

checkstyle / sonar-checkstyle

Support on Checkstyle in SonarQube. Officially transfered from https://github.com/SonarQubeCommunity/sonar-checkstyle
GNU Lesser General Public License v3.0
171 stars 70 forks source link

Issue #384: update to sonarqube 8.9 LTS #387

Closed muhlba91 closed 3 years ago

muhlba91 commented 3 years ago

fix #384

plugin starting and working (tested template and non-template check):

Screenshot 2021-10-29 at 8 44 52 AM
muhlba91 commented 3 years ago

@romani please review. let's be on-par with latest LTS before updating to 9.0.1 (#375).

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

romani commented 3 years ago

@muhlba91 , please update https://github.com/checkstyle/sonar-checkstyle/wiki/How-to-build-and-test-plugin-on-local to new version. I use this page a lot, when I come back to plugin, I do not remember all that nuances.

romani commented 3 years ago

@muhlba91 , does it make sense to combine this update with upgrade to checkstyle 9.0 ? so it will be to major upgrades in same time.

muhlba91 commented 3 years ago

@romani changed the wiki page and, yes, i would like to combine both updates with the 9.0 release. it fits well and i can anyways only submit a plugin with the lower boundary of 8.9 (8.42 and 8.45.1 is in the marketplace like this) as SQ will drop all plugins lower than than min. bound from the marketplace soon.

romani commented 3 years ago

Keep in mind that marketplace is good, but a lot user use old version of Sonar and plugins, manually installed