search

checkstyle / sonar-checkstyle

Support on Checkstyle in SonarQube. Officially transfered from https://github.com/SonarQubeCommunity/sonar-checkstyle
GNU Lesser General Public License v3.0
174 stars 70 forks source link

Issue #502: update to LTS 9.9; cleanup deprecations #503

Closed muhlba91 closed 8 months ago

muhlba91 commented 9 months ago

fixes #502 fixes #220 fixes #194

Also, remove the deprecated and to be removed ProfileImporter and ProfileExporter.

Screenshots of the working SQ:

Screenshot 2024-03-01 at 1 01 56 PM Screenshot 2024-03-01 at 1 01 35 PM
muhlba91 commented 9 months ago

@romani the main project deprecated AutomaticBean a while ago with the reference one should use AbstractAutomaticBean.

unfortunately, by doing so, i now receive a CS error:

[ERROR] [checkstyle] [ERROR] /projects/checkstyle/sonar-checkstyle/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java:41:1: Disallowed import - com.puppycrawl.tools.checkstyle.AbstractAutomaticBean. [ImportControlMain]

could you please advise here?

romani commented 9 months ago

please add this class to https://github.com/checkstyle/sonar-checkstyle/blob/8462c9e11258cacbf66990d6b512b8386bfbc1a2/config/import-control.xml#L21-L22 and disallow AutomaticBean when migration is completed.

muhlba91 commented 9 months ago

@romani could you please have a look? 😃

https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/878/workflows/9dfe6b2a-d89d-4cd9-b03b-7d7e95436488/jobs/1035 fails because the SQ java plugin is not compatible with java 11 anymore. i have updated the circleci job to use java 17 but this will only be applied once it's in master. (see change https://github.com/checkstyle/sonar-checkstyle/pull/503/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47)

https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/878/workflows/996f2d0a-8317-4ffe-9d15-027ecedb0db9/jobs/1037 fails but i don't know the reason, tbh. do you have any ideas here?

romani commented 9 months ago

Strange, stable failure. Restart ci on master is passing https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/860/workflows/cb6568c7-6dff-48ab-8f2e-9604d26c7f8a/jobs/1040

Something is this update

romani commented 9 months ago

Problem is at this step https://github.com/checkstyle/sonar-checkstyle/blob/f69a052208febb01d567f932731967986f6eb667/.circleci/config.yml#L26

It might not compatible with docker image for jdk 17, try to remove it or check with git blame why it was added

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

muhlba91 commented 8 months ago

awesome, thanks! 😃 circleci jobs are running through now and i migrated one of them to github actions as well.