Closed jsturgis closed 1 year ago
This change fixes a bug when loading the test-types eslint rule from checkup-plugin-ember. The rule failed to load because the rule file had a .cjs file elxtension and eslint only supports files with a .js file extension, see: https://github.com/eslint/eslint/blob/dd58cd4afa6ced9016c091fc99a702c97a3e44f0/lib/cli-engine/load-rules.js#L38
I also added a snapshot test to assert that the test type results are actually correct. Previously because the test was not checking the output, all of the types returned contained a rule load error but still passed.
This change fixes a bug when loading the test-types eslint rule from checkup-plugin-ember. The rule failed to load because the rule file had a .cjs file elxtension and eslint only supports files with a .js file extension, see: https://github.com/eslint/eslint/blob/dd58cd4afa6ced9016c091fc99a702c97a3e44f0/lib/cli-engine/load-rules.js#L38
I also added a snapshot test to assert that the test type results are actually correct. Previously because the test was not checking the output, all of the types returned contained a rule load error but still passed.