checkupjs / checkup

A health checkup for your project.
https://checkupjs.github.io/
MIT License
77 stars 23 forks source link

`eslint-disable-task` does not handle gjs/gts files since it only runs the babel parser #1347

Closed chrisrng closed 1 year ago

chrisrng commented 1 year ago

Unlike eslint-summary-task, eslint-disable-task does not pull in your eslintrc config so if your code is dependent on a specific preprocessor such as Ember's gts/gjs files it will fail where babel's FlowParserMixin throws Unexpected token

Ideally we can use ESLint with your eslintrc config file and expose a checkup eslint plugin with the no-disabled-eslint lint rule which the eslint-disable-task can collect.

Note for gts/gjs files eslint-plugin-ember already handles the <template> tags so you can run eslint directly

chrisrng commented 1 year ago

I see https://github.com/checkupjs/eslint-plugin-checkup already exists too but its empty :)

scalvert commented 1 year ago

What would prevent you from creating your own task that did precisely what you need? Essentially, checkup is just a structured executor of node tasks, so you should be able to create whatever you need.

chrisrng commented 1 year ago

The builtin task to me makes an assumption that doesn't work for gts/gjs files. At the very least we should remove them from the esLintablePaths if we move forward with creating a custom checkup task instead