checkuponme / Spoke

Politics Rewired's fork of Spoke, now forked for CheckUpOn.Me.
GNU General Public License v3.0
5 stars 1 forks source link

Buttons not appearing correctly #19

Open mcverter opened 4 years ago

mcverter commented 4 years ago

The buttons in the UI are tiny and have no text within them

Label is passed in as a prop <FlatButton label="Refresh Later" primary={true} onClick={this.handleClose} />

This is acceptable in material_ui^0.20.1 but isn't being translated into a text label in the HTML output

tcallred commented 4 years ago

This is also happening with <Form.Button ... which is coming from react-formal. See CreateOrganization.jsx. I'm still not entirely sure what's causing the problem but the docs for react-formal only have examples using <Form.Submit .... The props being passed to Form.Button are also causing errors.

mcverter commented 4 years ago

Thanks for pointing that out. I have a quick fix for the issue, but will dig deeper. https://github.com/checkuponme/Spoke/commit/42c40c7d8f74ec688852962598617aa4250738fb

mcverter commented 4 years ago

https://github.com/checkuponme/Spoke/compare/14f4b9f..19d200e https://github.com/checkuponme/Spoke/commits/mverter_ui_fixes is the fix

mcverter commented 4 years ago

not yet merged