cheddar-lang / Cheddar

🧀 Cheddar, the language that works for you

cheddar.vihan.org

Apache License 2.0

28 stars 9 forks source link

This should fix it #101

Closed kckennylau closed 7 years ago

somebody1234 commented 7 years ago

This won't fix it, tail means last n chars, what you've changed it to do is make it return all but first n chars.

codecov-io commented 7 years ago

Codecov Report

Merging #101 into develop will not change coverage. The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop     #101   +/-   ##
========================================
  Coverage    77.14%   77.14%           
========================================
  Files          148      148           
  Lines         2722     2722           
  Branches       639      639           
========================================
  Hits          2100     2100           
  Misses         618      618           
  Partials         4        4

Impacted Files	Coverage Δ
src/stdlib/primitive/String/lib/tail.es6	`25% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 890db21...66a533d. Read the comment docs.

kckennylau commented 7 years ago

What about now?

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling ff177d19db09ae197b1ffa70a18892a3bdd551fb on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling ff177d19db09ae197b1ffa70a18892a3bdd551fb on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling ff177d19db09ae197b1ffa70a18892a3bdd551fb on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.

somebody1234 commented 7 years ago

@kckennylau Now it returns all buut last n chars, the original was correct

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling 05c80277ada9d366472b40e58f055dbf58bcf822 on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.

kckennylau commented 7 years ago

I've updated it again.

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling 05c80277ada9d366472b40e58f055dbf58bcf822 on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling 05c80277ada9d366472b40e58f055dbf58bcf822 on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.

somebody1234 commented 7 years ago

Oh yeah it was supposed to be a slice, but the 0, is unneeded.

kckennylau commented 7 years ago

You can delete the 0, then.

coveralls commented 7 years ago

Coverage remained the same at 79.573% when pulling 66a533df42a34bd1ca2bc3677e3115f29633f558 on kckennylau:patch-1 into 890db21f24e4aaf47ebfb84def4e3f30127155b6 on cheddar-lang:develop.