search

cheeaun / hackerweb

A simply readable Hacker News web app
http://hackerwebapp.com/
1.23k stars 133 forks source link

Added "apple-" prefix to "-mobile-web-app-capable meta tag" #40

Closed shubhadeep closed 2 years ago

shubhadeep commented 9 years ago

Added "apple-" prefix to "-mobile-web-app-capable meta tag" as it was missing. See https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html for valid tags.

cheeaun commented 9 years ago

Two things:

  1. mobile-web-app-capable was meant only for Chrome mobile 90fc0373fb28f8869f251f1d9001fbba7b5e7e6d. I realise that the link in the commit message is borked, so here's the updated URL: https://developer.chrome.com/multidevice/android/installtohomescreen
  2. apple- prefix is not added on purpose because it was (and still, I think?) very buggy as it affects lots of things like offline caching, history navigation and external-page linking.

Thanks for the PR, but don't think I'll merge it.

Cheers :smile:

shubhadeep commented 9 years ago

Thank you. I did know about the chrome specific meta tag. Currently testing with the apple prefixed tag on ios 7. Let me see how buggy it is - I can see right away that external page links are launching safari.

cheeaun commented 9 years ago

@shubhadeep sure :smile: I haven't test it for months now. In fact I added that and removed it since the very first release (~4 years ago?) due to the bugs. I was hesitant to add mobile-web-app-capable last year because afraid that Chrome mobile might have the same bugs but turns out okay.