Prevents long URLs from breaking the layout.

cheeaun / hackerweb

A simply readable Hacker News web app

http://hackerwebapp.com/

1.23k stars 133 forks source link

Prevents long URLs from breaking the layout. #42

Closed dreger closed 3 years ago

dreger commented 9 years ago

Re: https://github.com/cheeaun/hackerweb/issues/29

This commit changes the span.link-text element to a block layout, which allows us to apply the CSS text-overflow: ellipsis; rule to long URLs. I've also removed the now unnecessary <br> tag in the post template, as block layout elements do not require manual line breaks.

cheeaun commented 9 years ago

Just wondering how do you test this? I've tried it on Mobile emulation mode in Chrome, it's still kinda breaks the layout :disappointed:

cheeaun commented 9 years ago

It still pushes the comment button away.

push-hackerweb

dreger commented 9 years ago

Hmm... I only made changes to the hw-ios-*.css files, so it might be breaking because I'm not catching the non-iOS hw-web.css stylesheet - which I can fix. I think things are fixed for iOS browsers, however: