crash on nightly when clicking link that opens in new tab

cheeaun / max-tabs

A no-restart Firefox extension to set maximum number of opened tabs in a window.

https://addons.mozilla.org/en-US/firefox/addon/max-tabs/

8 stars 20 forks source link

crash on nightly when clicking link that opens in new tab #21

Open rhelmer opened 9 years ago

rhelmer commented 9 years ago

I've been seeing a crash for a while on Nightly, I can easily repro:

<!DOCTYPE html>
<html>
  <body>
    <a target="_blank" href="repro.html">click me</a>
  </body>
</html>

Open 10 tabs (default limit), load this in one of then and click the link.

rhelmer commented 9 years ago

Here's the crash: https://crash-stats.mozilla.com/report/index/27892aa8-a38c-4f5f-9ec4-efa632150827

rhelmer commented 9 years ago

~~Oh, you know what.. I have "Open new windows in a new tab instead" checked in the preferences... I'll update that with something that works in a new profile.~~

EDIT - actually looks like browser.link.open_newwindow is set this way by default (3), for some reason it's not getting set that way when I use jpm run or npm start though...

Looks like this is caused by https://github.com/saadtazi/firefox-profile-js/blob/master/lib/firefox_profile.js#L34