search

cheeaun / max-tabs

A no-restart Firefox extension to set maximum number of opened tabs in a window.
https://addons.mozilla.org/en-US/firefox/addon/max-tabs/
8 stars 20 forks source link

Tab indicator resets after browser shutdown #3

Closed ghost closed 10 years ago

ghost commented 10 years ago

The tab indicator, which is placed in the addon bar by default resets itself after every browser shutdown. If you manually drag it to the toolbox so it isn't shown anymore, it will be back in the addon bar after a browser shutdown.

Normally this didn't bother me so much because I just hid the addon bar. But if you test out the current nightlies with the new australis design it stands in the main navigation toolbar and can't even be moved. The addon bar is removed in the australis redesign.

Can you fix this please?
I think not much users are going to like this when Australis lands in the normal releases.

Thank you!

cheeaun commented 10 years ago

May I know which version of Firefox are you using? The extension doesn't really control where it positions itself so I expect that to be a bug in Firefox.

ghost commented 10 years ago

I use multiple versions, but the problem occurs in every version from stable Firefox (version 25) till the current nightlies which do have the new australis theme. It is in the nightlies that it becomes annoying as you can’t (re)move the tab counter from the main toolbar. You can see for yourself if you download a nightly at http://nightly.mozilla.org/ and install the max tabs extension.

Thanks!

On 29 Nov 2013, at 03:12, Lim Chee Aun notifications@github.com wrote:

May I know which version of Firefox are you using? The extension doesn't really control where it positions itself so I expect that to be a bug in Firefox.

— Reply to this email directly or view it on GitHub.

cheeaun commented 10 years ago

Just wondering, does this happen to other (restartless) extension that you might have? I tried to replicate this on my Firefox Aurora 27.0a2 and the counter position didn't reset.

As for the nightlies, I'll keep an eye on this issue. Do note that I usually don't fix bugs that were introduced in nightlies because things are still in flux and sometimes such bugs could be fixed (by Firefox devs) by the time it reaches Aurora/Beta/Stable release.

ghost commented 10 years ago

No, only with max-tabs unfortunately. I understand that you don’t want to bother with nightlies. But as it only occurs with your add-on, I thought there was some kind of boolean or flag you have to set for it to not reset its value after every browser shutdown.

On 29 Nov 2013, at 18:28, Lim Chee Aun notifications@github.com wrote:

Just wondering, does this happen to other (restartless) extension that you might have? I tried to replicate this on my Firefox Aurora 27.0a2 and the counter position didn't reset.

As for the nightlies, I'll keep an eye on this issue. Do note that I usually don't fix bugs that were introduced in nightlies because things are still in flux and sometimes such bugs could be fixed (by Firefox devs) by the time it reaches Aurora/Beta/Stable release.

— Reply to this email directly or view it on GitHub.

ghost commented 10 years ago

In recent nightlies the indicator does indeed stay away. However I also use the stable version of Firefox (now at 26) and the problem persists there. The indicator resets itself to the addon bar after every browser shutdown or restart. Manually dragging it to the customize buttons dialog removes it only for that browsing session. It doesn't reset its position if you set it somewhere in the addon or navigation toolbar but it does if you move it away.

ghost commented 10 years ago

In the latest version of Firefox (with new Australis redesign) the behaviour seems to have been fixed. So this can be closed now. Thank you for your help!

cheeaun commented 10 years ago

@exatto thanks for verifying the bug! :)