search

cheeaun / octofication

A nifty little Chrome extension for displaying GitHub notifications.
https://chrome.google.com/webstore/detail/octofication/ooicpiadbdjcbbhamalpmdkececehgil
17 stars 2 forks source link

Pull Request URL #1

Open gwagner opened 12 years ago

gwagner commented 12 years ago

For some reason your app is taking me to /user/repo/pulls/# instead of /usr/repo/pull/# (Pull not Pulls)

So every time i click on something it is broken. Can you please fix?

cheeaun commented 12 years ago

@gwagner does it load a 404 page? From what I see, the URLs usually come from GitHub's API which is not modified in any forms. Would be great if you can give more details and perhaps compare the notifications list in both the extension and the site.

gwagner commented 12 years ago

Right now i have a pull request from mongodb/mongo-php-driver and your app directs me to the link: https://github.com/mongodb/mongo-php-driver/pulls/217

You should subscribe to that project and see where the API takes you. And no i do not get a 404 page.

It should take you to https://github.com/mongodb/mongo-php-driver/pull/217

gwagner commented 12 years ago

So i can confirm that your recent changes fixed the pulls / pull URL problem. :+1:

I am unable use any link that links directly to a private repo. I always get the "Uh-oh and unexpected error has occurred" :frowning:

Also you are missing one R in the word occurred in your error message.

cheeaun commented 12 years ago

Reopening this, and will try that private repo bug. @gwagner Is it a link to an 'issue' or a 'pull request'? Or something else?

gwagner commented 12 years ago

It is a link to a pull request in a private repo. So someone leaves a comment on a pull request and that pull request shows up as a notification.

Sent from my iPhone

On Nov 20, 2012, at 7:25 PM, Lim Chee Aun notifications@github.com wrote:

Reopening this, and will try that private repo bug. @gwagnerhttps://github.com/gwagnerIs it a link to an 'issue' or a 'pull request'? Or something else?

— Reply to this email directly or view it on GitHubhttps://github.com/cheeaun/octofication/issues/1#issuecomment-10582144.

cheeaun commented 12 years ago

I think this is probably fixed by 49b9ffabcd820a9f585030b862b8188995110cf6 , would be great if you can confirm it.

gwagner commented 12 years ago

I will let you know once i get a new PR on a private repo. Thanks for the help!

gwagner commented 12 years ago

I just got a notification about a new commit in a private repo, and i still get the same error. It is showing up as a comment in their API if that helps at all.

Is there anything i can do to help debug?

cheeaun commented 12 years ago

@gwagner it shows up a comment in the API? Not sure if I get that but it would be great if you can check few things:

  1. Which version of Octofication you're using. Go to Extensions page, check there. Should be 0.5.
  2. Does it pop the error dialog at the top of the extension popup?
  3. Try uninstall and reinstall the extension. If things start working after this, I'll know the exact cause then.

Thanks.

gwagner commented 12 years ago
  1. Yes i am
  2. Yes it does
  3. I just removed and re-installed. I will let you know when i have a private notification to test.
gwagner commented 11 years ago

Still giving me an error at the top of the screen for private repos.

The other thing i noticed is, once i click the mark all as read button, you keep the links on the screen and GH expires all of the links as soon as the API call is made. So once i click Mark all as read, i have a bunch of dead links sitting there that i can not go back and click.