cheeaun / phanpy

A minimalistic opinionated Mastodon web client
https://phanpy.social
MIT License
1.08k stars 107 forks source link

[FR] Improving viewing image experience #100

Open nhan000 opened 1 year ago

nhan000 commented 1 year ago

I hope the video would be easier to understand than text: https://youtu.be/dwVnCEe2gVg

In the video I'm using this thread: https://phanpy.social/#/pkm.social/s/110169741586783061 And this is the comment I want to view comfortably (without having to click into it): https://phanpy.social/#/pkm.social/s/110182364639376007

In short I want the text panel that takes up the right half of the screen to stay intact when you open an image (less transitioning is better). The image will take up the left half of the screen. There's just so much space around an image in the current layout while the text is squished to the right. If users want to view the full original image they still have the option to view original media:

image

A few minor points to improve:

If any of the above is hard to implement, just doing this https://github.com/cheeaun/phanpy/issues/99 is already a good improvement.

Thanks so much!

nhan000 commented 1 year ago

It's been improved a lot with the latest update. There're just 2 things I want:

https://user-images.githubusercontent.com/85216095/234540918-53a32b08-dc6f-4779-892d-4be6737405d0.mp4

cheeaun commented 1 year ago

Currently when switching between images, an image is first stretches to fit the viewing window before returning to its original size which can be jarring (see video below).

This is a bug, I'll need to spend some time to fix this. From technical side, the first image is actually the smaller image, which gives the "preloading" effect. The one's loading on top of it is the original larger image, which will take longer time to download.

Any reason why you don't want to fit the image to the viewing window? To me it make the view experience better. (Or provide a toggle here if people may not like it?)

I think the experience really depends on the image. If fit image to viewing window, easier to implement actually. But there are folks who post images which are too small (e.g. 16x16 which will look ugly when stretched. I'm aiming for the original dimensions of the image, and scale down if it can't fit inside - which seems to require more adjustments (in the code).