Youtube videos open into a hilariously small embed

[jeromechoo]

Describe the bug Opening a Youtube video from a post leads to a view with a working video embed but it is extremely small as to be unviewable unless full screened.

To Reproduce Steps to reproduce the behavior:

1. Go to https://phanpy.social/#/masto.ai/s/111779108628881994
2. Click on the video

Expected behavior Video should scale to something appropriate to the viewport size.

Screenshots Current size:

Proposed size:

Desktop (please complete the following information):

• OS: 15" Macbook Air M2, 2023
• Browser: Firefox
• Version: 121.0.1 (64-bit)

Additional context Reproducible across latest Chrome and Safari.

[Alex0007]

My proposal is: replace link preview with youtube player directly in post body (onClick). This empty modal makes no sense

[Alex0007]

Youtube embeds are still small

[cheeaun]

@Alex0007 do you have a link to the post? Suspect the dimensions are from the API response which probably points to the thumbnail sizes. Else, I don't see any way to know the video's actual dimensions (Video is inside an iframe of another site which won't expose any info).

One possible way, is to not follow dimensions from API response and make it as huge as possible, and hopefully the content inside the iframe knows how to fix its own layout 🤔

Edit: I just checked; I hard-coded a max width of 480px now set on Phanpy's side.

[Alex0007]

@cheeaun yeah it's still hilariously small 😑 i'd say that modal with small youtube frame is useless (blocks every other functionality + video is unwatchable without going to fullscreen because of small size)

[Alex0007]

Still! (sorry for bumping this issue, but it just looks weird every time i get to that screen)