search

cheeaun / phanpy

A minimalistic opinionated Mastodon web client
https://phanpy.social
MIT License
1.08k stars 107 forks source link

inconsistant width of media when logged in via Pixelfed account #491

Open wakest opened 7 months ago

wakest commented 7 months ago

this goes away if you make the window quite narrow and force mobile layout

image

I would expect all posts to have the same width on the timeline regardless of window size

tested on dev.phanpy.social (version) Firefox 124.0.2 (64-bit) macOS 13.6.4

cheeaun commented 7 months ago

Currently on wider viewport, the design tries to respect the original/natural dimension of the media attachments. The max width will always be the viewport width.

I noticed that most photos and videos on Pixelfed are very nicely taken/made with standard dimensions and aspect ratios. But posts from non-Pixelfed instances don't quite… follow this. Small images (usually pixel art) could look stretched, wide images could look too small, etc.

iamperfor commented 7 months ago

@cheeaun is it possible to have all post box width the same size but image can retain the natural dimension inside of the post box? Using the image from @wakest as example, the username and time stamp will then all be aligned

cheeaun commented 7 months ago

Currently the post box design have two widths. Wide for landscape images, narrow for square/portrait images. It'll also respect natural width and height, within the post box, without exceeding the max.

@iamperfor current implementation does retain natural dimension inside too, though it'll look even more uneven in fact. It's more apparent for portrait images that have height exceeding the the max height (viewport), thus reducing its width and it'll look "cropped" on the left and right sides.

It's quite a tough balancing game here 🙈. Max height is needed to prevent super-tall images. They had to be cropped at some point but will need more math and specific breakpoints. Wider post box is to give chance for those panorama/landscape photos to shine. IG initially started with square images and later on allowed (limited, slightly cropped) portraits, but never really try make landscape photos better — it's not possible on mobile, but should at least look better on wider screens 😄.

Note that this is still experimental and looks different than any other (conventional?) sites that I'm aware of.