cheeaun / phanpy

A minimalistic opinionated Mastodon web client
https://phanpy.social
MIT License
935 stars 85 forks source link

Error on Settings #559

Open Fastidious opened 3 weeks ago

Fastidious commented 3 weeks ago

Describe the bug Using Phanpy with GoToSocial. When going to "Settings" I am getting a small bubble at the top of the page stating:

Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.

Can't enable notifications either. I get:

Failed to update subcription. Please try again.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings'.
  2. See error on bubble at the top of the page.
  3. Click on "Allow from Anyone", and pick "Follow", etc.
  4. See error on bubble at the top of the page.

Expected behavior I would expect for things to work.

Desktop (please complete the following information):

Not sure if this is something not supported by GoToSocial.

Fastidious commented 3 weeks ago

This is happening at https://m.ferengi.one/ running bleeding edgeish (2024.06.03.6d7eddc). Issue doesn't show on https://phanpy.social/.

Fastidious commented 3 weeks ago

Hmm, well, clearing the cache fixed this issue. I have two accounts configured, maybe trying to set notifications for both caused the issue? In any case, it is now gone. Will close this issue later today.

Fastidious commented 3 weeks ago

Well, now it is the notifications they aren’t working. Tick the boxes and they do not stick. All this is happening on settings.

Fastidious commented 3 weeks ago

I might have gotten confused all along. GoToSocial doesn’t support pushed notifications yet, so I figure the notifications setting never worked with it. Sorry about the noise. 😞

cheeaun commented 3 weeks ago

Hmm I could add a few checks in the code — it just assumes that the web push API is supported. Probably need to figure out how to know if the instance supports web push 🤔