cheeaun / phanpy

A minimalistic opinionated Mastodon web client
https://phanpy.social
MIT License
1.09k stars 107 forks source link

[Firefox Containers] Can't login into account if Phanpy or account opened inside container #667

Open SadmL opened 2 months ago

SadmL commented 2 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to phanpy.sadium.cyou (containerized or not)
  2. Click on 'Login'
  3. Authorize in instance (containerized or not, opposite to step 1, or both containerized)
  4. Looks like login happens, but no account was added into Phanpy

Expected behavior Go to phanpy.sadium.cyou -> Login -> Authorize -> Account is added in Phanpy (repeat x2 in my case)

Screenshots No login изображение

Logged in изображение

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context If no containers used or account and Phanpy inside same container, no problems with login. Elk client doesn't have such problem.

285 may be related, but both instances uses subdomains as @subdomain.domain.com

cheeaun commented 2 months ago

If login works without containers, it's probably not a subdomain issue.

This is a bit hard for me to replicate. Are you able to debug this on your side, maybe looking at the browser devtools console? 🙏

SadmL commented 2 months ago

If I know how to debug 😅 May be this will be helpful изображение

SadmL commented 2 months ago

I don't think that is OS related, more likely just Firefox containers. For example I want to use Github for Crowdin login. Github in container 1 Crowdin - no container No container Crowdin - Press login - redirect to containerized Github - Github authorization - redirects back into Crowdin with no container and Github based account - profit

cheeaun commented 2 months ago

@SadmL if this is your own server and the admin, is it possible if you create a temporary dummy account for me to test? Private mention me the details.

SadmL commented 2 months ago

Check DM

SadmL commented 2 months ago

I've rebuild with latest https://github.com/cheeaun/phanpy/commit/58ccdf84fad03f24e04f815e6fed331813043f12 and looks like it's working now

anhgelus commented 2 months ago

If you are switching containers during the login (e.g., phanpy is in container A and your instance is in container B), it sends you an HTTP 401 or an HTTP 403