search

cheecheeo / haskell-cgi

A library for writing CGI programs
Other
5 stars 9 forks source link

Added HttpOnly option to cookies #32

Closed bneuen closed 8 years ago

bneuen commented 8 years ago

More information on HttpOnly: https://en.wikipedia.org/wiki/HTTP_cookie#HttpOnly_cookie

cheecheeo commented 8 years ago

@bneuen I've merged this patch to https://github.com/cheecheeo/haskell-cgi/tree/next as it will require a new major version. Do you have an urgent need for this change to be released?

bneuen commented 8 years ago

No, no rush here. I was just using the library, and thought the httpOnly flag could be a useful (security) feature, so I added it.

Is a major version release necessary (perhaps it is protocol to do so)? I think adding that field should be backward compatible with everything.

Thanks, -Bowe

On Mon, Sep 5, 2016 at 9:18 PM, John Chee notifications@github.com wrote:

@bneuen https://github.com/bneuen I've merged this patch to https://github.com/cheecheeo/haskell-cgi/tree/next as it will require a new major version. Do you have an urgent need for this change to be released?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cheecheeo/haskell-cgi/pull/32#issuecomment-244834576, or mute the thread https://github.com/notifications/unsubscribe-auth/AGsY4o9g2py17knw7O0ShpbP5IJK1MuOks5qnM1wgaJpZM4JzaNV .

cheecheeo commented 8 years ago

According to my reading the PVP this will require a new major version (probably 3001.4).

http://pvp.haskell.org/

Breaking change. If any entity was removed, or the types of any entities or the definitions of datatypes or classes were changed, or orphan instances were added or any instances were removed, then the new A.B MUST be greater than the previous A.B. Note that modifying imports or depending on a newer version of another package may cause extra orphan instances to be exported and thus force a major version change.

Thanks for the contribution 💯