search

cheekybits / genny

Elegant generics for Go
MIT License
1.71k stars 127 forks source link

Remove comment for generic.Type #1

Closed matryer closed 9 years ago

matryer commented 9 years ago

If users write a comment above generic.Type (as per golint), we should remove it when generating specific code to avoid orphan comments.

tylerstillwater commented 9 years ago

Any thoughts on how to go about this? I'm not as familiar with the ast stuff as you are. Would this be a raw change we do to a buffer directly?

matryer commented 9 years ago

I wonder if at the point of detecting the type, we can look back to see if there’s a comment associated with it!?

Or else, keep the ‘last comment’ reference.

I have no idea too :D

On Dec 1, 2014, at 12:36 PM, Tyler notifications@github.com wrote:

Any thoughts on how to go about this? I'm not as familiar with the ast stuff as you are. Would this be a raw change we do to a buffer directly?

— Reply to this email directly or view it on GitHub https://github.com/cheekybits/genny/issues/1#issuecomment-65130233.

tylerstillwater commented 9 years ago

Can you link me to where we "detect the type"?

On Mon, Dec 1, 2014 at 1:38 PM, Mat Ryer notifications@github.com wrote:

I wonder if at the point of detecting the type, we can look back to see if there’s a comment associated with it!? Or else, keep the ‘last comment’ reference. I have no idea too :D

On Dec 1, 2014, at 12:36 PM, Tyler notifications@github.com wrote:

Any thoughts on how to go about this? I'm not as familiar with the ast stuff as you are. Would this be a raw change we do to a buffer directly?

— Reply to this email directly or view it on GitHub https://github.com/cheekybits/genny/issues/1#issuecomment-65130233.

Reply to this email directly or view it on GitHub: https://github.com/cheekybits/genny/issues/1#issuecomment-65130624

matryer commented 9 years ago

Wow I didn't realize this was done. Great work.