cheelim1 / terraform-provider-jumpcloud

A Terraform provider for JumpCloud
MIT License
5 stars 2 forks source link

Setting user display name #10

Closed sinamiandashti-fior closed 6 months ago

sinamiandashti-fior commented 6 months ago

Hello Is there a way to set the user display name via your provider?

cheelim1 commented 6 months ago

@sinamiandashti-fior just noticed this, did you mean setting a user display name for this resource https://registry.terraform.io/providers/cheelim1/jumpcloud/latest/docs/resources/user?

sinamiandashti-fior commented 6 months ago

exactly @cheelim1

cheelim1 commented 6 months ago

@sinamiandashti-fior It did not support display name initially but i have just pushed a new version 0.3.11 to support display_name since you requested. Do refer to the docs: https://registry.terraform.io/providers/cheelim1/jumpcloud/latest/docs/resources/user

cheelim1 commented 6 months ago

Do close the issue once you have tested it out and works as expected. Thanks.

sinamiandashti-fior commented 6 months ago

Thanks a lot for this Could you also please add alternative email support? so we can set user secondary/alternative email to the user resource? @cheelim1

sinamiandashti-fior commented 6 months ago

Also there is a problem updating the package to 0.3.11 or 0.3.13

`Initializing the backend... Upgrading modules...

  • organization_jumpcloud_groups in ../../modules/__group
  • organization_jumpcloud_people in ../../modules/__people

Initializing provider plugins...

  • Finding cheelim1/jumpcloud versions matching "0.3.10, 0.3.11"... ╷ │ Error: Failed to query available provider packages │ │ Could not retrieve the list of available versions for provider cheelim1/jumpcloud: no available releases match the given constraints 0.3.10, 0.3.11 ╵ `

@cheelim1

cheelim1 commented 6 months ago

Unfortunately, i don't think i would be able to add alternative email anytime soon, because the current dependency which is the jumpcloud go sdk doesn't support it https://github.com/TheJumpCloud/jcapi-go. Do let me know if there are any other fields you would need support and i can take a look.

I can potentially either look to update the jumpcloud go sdk or switch to directly call the jumpcloud API in order to support it which won't be anytime soon.

cheelim1 commented 6 months ago

As for updating your terraform provider, ensure to run terraform init -upgrade to upgrade to the latest version

example updating the version to hardcode the version or use `"~>0.3.10"

terraform {
  required_providers {
    jumpcloud = {
      source  = "cheelim1/jumpcloud"
      version = "0.3.13"
    }
  }
}

provider "jumpcloud" {
  api_key = "xxx"
}
sinamiandashti-fior commented 6 months ago

Exactly did what you suggested getting this

❯ terraform init -upgrade

Initializing the backend... Upgrading modules...

  • organization_jumpcloud_groups in ../../modules/__group
  • organization_jumpcloud_people in ../../modules/__people

Initializing provider plugins...

  • Finding cheelim1/jumpcloud versions matching "0.3.10, 0.3.13"... ╷ │ Error: Failed to query available provider packages │ │ Could not retrieve the list of available versions for provider cheelim1/jumpcloud: no available releases match the given constraints 0.3.10, 0.3.13 ╵

Is this working for you? @cheelim1

sinamiandashti-fior commented 6 months ago

i got the issue works now thanks a lot @cheelim1

cheelim1 commented 6 months ago

Just sharing, I also open an issue https://github.com/TheJumpCloud/jcapi-go/issues/58 to get them to support the alternate email field in the sdk.