search

cheery / node-udev

Bindings to libudev
35 stars 31 forks source link

v8::ObjectTemplate::Set() with non-primitive values is deprecated #15

Closed matianfu closed 7 years ago

matianfu commented 7 years ago

Got this warning in Node.js 6.6.0, Ubuntu 16.04.

cheery commented 7 years ago

This issue elsewhere proposes that update of nan -package will fix this.

nbroeking commented 7 years ago

Is there an update or a fix for this? The fix cheery commented on last does not work. Is there a plan to update the udev package?

cheery commented 7 years ago

No current plans if the fix does not work. Anyone willing to fix this issue has free hands to do so and put a pull request.

cheery commented 7 years ago

@matianfu, @nbroeking nan package version was bumped up and it fixed the #17

I also ran npm publish. Might not fix anything here but good thing to try.

When I run npm install udev, it warns about TryCatch deprecated. It's not a big thing so I let it be for now.

nbroeking commented 7 years ago

@cheery Thank you! I tested it this morning. Everything works great.

cheery commented 7 years ago

@nbroeking If anything else goes bad, file a new issue. Thanks for checking.