search

cheery / node-udev

Bindings to libudev
35 stars 31 forks source link

Fails to install/compile under node v12.10.0 #30

Open gk1 opened 5 years ago

gk1 commented 5 years ago

udev-install.txt

cheery commented 5 years ago

Node devs at it again. I got better things to do than clean up after they've Impulse-changed some trivial detail in same manner as Barbie changes her clothes. For example right now I'm taking a shit. That's better thing to do than fix after them. Fuck them.

to 12. syysk. 2019 klo 0.53 Greg Kennedy notifications@github.com kirjoitti:

udev-install.txt https://github.com/cheery/node-udev/files/3602876/udev-install.txt

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cheery/node-udev/issues/30?email_source=notifications&email_token=AAJIXPCGITZO2V4SLFW5FZDQJFSFBA5CNFSM4IVZISR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HK2XJ2Q, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJIXPGPSBN3IJDHQJMGZTTQJFSFBANCNFSM4IVZISRQ .

jacobq commented 5 years ago

@cheery, wow, and it looks like you're even using nan which is supposed to make those compatibility nightmares mostly go away...

Would you mind updating the engines section of your package.json so it's clear what versions of Node this package actually does support? It looks like it works with 10.x but not with 12.x, which is scheduled to become LTS in about a week.

mortie commented 5 years ago

In 2017, after https://github.com/cheery/node-udev/issues/19, I decided to just write my own udev library, where the udev part is a tiny C program which emits JSON on stdout and accepts commands on stdin, with some javascript to wrap it: https://github.com/mortie/dedaemon/tree/master/udev

It's not documented, and probably not feature complete, and I never put it up as its own package, but it has just sat there and worked without being touched for those two and a half years. As long as core node.js libraries and the udev C library doesn't change, it'll work for many more. Might be something to consider.

I've used Google C++ libraries before. Nothing they actively work on is ever anywhere near stable. As long as you're using stuff from the V8 namespace, I imagine breakages will continue until the node.js team stops upgrading to new versions of V8.

Also, compare http://npm.broofa.com/?q=udev and http://npm.broofa.com/?q=dedaemon ;)

lucamarogna commented 4 years ago

Try this fork: https://github.com/ConnectionSystems/node-udev I think it worths a look because it actually works with NodeJS 12 and perphaps you can integrate his Pull Request into your project.

Just reach out to him if you would to.

jacobq commented 4 years ago

@donlucacorleone thanks for pointing out https://github.com/ConnectionSystems/node-udev/commit/39957a93b7d987f869869f9e893bcc65ee0afbd5 (though I don't see any open PR)

miteshdube commented 4 years ago

@donlucacorleone Thank you for this repository it solved my problem.

miteshdube commented 4 years ago

Can anyone tell me where i'll get API for node-udev?