search

cheese10yun / spring-jpa-best-practices

:octocat: spring-jpa best practices
1.08k stars 241 forks source link

테스트 코드 수정 #69

Closed ofnullable closed 5 years ago

ofnullable commented 5 years ago

안녕하세요! 우선 좋은 내용 공유해주셔서 감사드리고 재미있게 공부하고있습니다! 테스트코드 중 Delivery에 log 추가하는 부분이 Delivery 클래스의 addLog 메서드를 활용하는것이 더 좋아보여 수정해봤습니다. 혹시 의도하신 부분이 아니라면 피드백 부탁드리겠습니다 :smiley:

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 168

Totals Coverage Status
Change from base Build 167: 0.0%
Covered Lines: 365
Relevant Lines: 372
💛 - Coveralls
codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage     97.58%   97.58%           
  Complexity      128      128           
=========================================
  Files            37       37           
  Lines           372      372           
  Branches          4        4           
=========================================
  Hits            363      363           
  Misses            7        7           
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daf18e6...437e51f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage     97.58%   97.58%           
  Complexity      128      128           
=========================================
  Files            37       37           
  Lines           372      372           
  Branches          4        4           
=========================================
  Hits            363      363           
  Misses            7        7           
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daf18e6...437e51f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage     97.58%   97.58%           
  Complexity      128      128           
=========================================
  Files            37       37           
  Lines           372      372           
  Branches          4        4           
=========================================
  Hits            363      363           
  Misses            7        7           
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daf18e6...437e51f. Read the comment docs.

cheese10yun commented 5 years ago

감사합니다. 의도한 부분은 아닙니다. 실수입니다. PR 감사합니다.