search

cheesecakeufo / komorebi

A beautiful and customizable wallpapers manager for Linux
GNU General Public License v3.0
3.37k stars 235 forks source link

AUR package #2

Open ghost opened 7 years ago

ghost commented 7 years ago

Can you make one, also, if it gains high popularity it'll end in the official repos.

cheesecakeufo commented 7 years ago

I haven't built an AUR package before, but I'll look into it. The reason I'm doing only .deb for now is because it is automated inside of CMake. Not sure about automation for AUR packages :)

ghost commented 7 years ago

can you please set install location to /usr/bin and /usr/share instead of /System? because it is against AUR standards https://wiki.archlinux.org/index.php/Arch_packaging_standards#Directories

paschoal commented 7 years ago

my suggestion is to use a different CMakeLists.txt for Aur/Arch, so you can keep different paths for different distros.

The one I used to compile it for my Arch system. CMakeList.txt

juippis commented 7 years ago

Only changing CMakeLists.txt with paths isnt probably enough since the /System/ paths are written directly into source files. Ive come around this with few lines of sed, 

   sed -i 's|/System/Applications/|/usr/bin/|g' CMakeLists.txt
   sed -i 's|/System/Resources/Komorebi|/usr/share/komorebi|g' CMakeLists.txt
   sed -i '/$ENV{HOME}/d' CMakeLists.txt

   sed -i 's|/System/Resources/Komorebi|/usr/share/komorebi|g' src/OnScreen/InfoBox.vala
   sed -i 's|/System/Resources/Komorebi|/usr/share/komorebi|g' src/OnScreen/BackgroundWindow.vala
   sed -i 's|/System/Resources/Komorebi|/usr/share/komorebi|g' src/OnScreen/PreferencesWindow.vala

Ive made an ebuild for Gentoo that uses "sane" directory hierarchy and works.

cheesecakeufo commented 7 years ago

@arunsai123 The reason it is setup to install to /System/ is because Komorebi was designed for Kedos OS but made compatible with Ubuntu. @paschoal Changing the install directory through CMakeLists simply won't make Komorebi work since the /System/ paths are inside of the source code. Now that @juippis has built a script that changes all directories to the desired one, that would actually fix the issue. I also can add a custom key 'KOMOREBI_DIRECTORIES' where you can change the executable path as well as resources path. That key can be used in both Installing Komorebi as well as inside of the source code.

paschoal commented 7 years ago

@arunsai123 awesome, I didn't had time to check this yet, but I will test soon. @iabem97 please let us know if you plan to push to AUR or need help with this.

cheesecakeufo commented 7 years ago

@paschoal I would love to have Komorebi on AUR but I can't push it at the moment since Komorebi isn't 1.0 (stable) yet, and I haven't really worked with AUR. Is there a script or an extension to CMake to automatically generate AUR package?

paschoal commented 7 years ago

@iabem97 my understanding is the other way around, the AUR package (which is basically a PKGBUILD file) has the instructions on how to setup and compile using CMAKE, the AUR package would not hold any piece of code per se, just instruction on what to clone (from git) and how to build it.

about hitting the version 1.0, a common approach in the community is to have a package named -git, like komorebi-git, that would point to HEAD of the repo, and then a komorebi package that would point to the latest release.

anybody using the git package would be aware that this is unstable and may have a weird behaviour

FabioLolix commented 6 years ago

An AUR package for this exist https://aur.archlinux.org/packages/komorebi