[Android Bootcamp] App Review - Twitter sample app

[cheesecow]

@nesquena @timothy1ee

[nesquena]

:+1: Looks good Eric, a few points of feedback:

• Properly leveraged RestClientTemplate and configured TwitterClient to authenticate and send requests to API
• Leveraged UniversalImageLoader to load all remote images
• Setup login with OAuthLoginActivity and handled onLoginSuccess
• Properly setup Tweet and User models extracting relevant data from JSON
• Properly setup home timeline request through TwitterClient and tweets are displayed in timeline ListView
• You should consider handling the onFailure case as well as onSuccess when working with async requests. Otherwise things will be totally unhandled and broken without internet or if a request fails.
• Setup compose window properly posting tweet
• Consider adding a character counter to your compose view to show # of characters remaining
• Reloaded home timeline to display the tweet after tweet was submitted
• Didn't add pagination, you might want to check out our guide on endless scrolling.
• Consider playing around with ActiveAndroid for persistence of last 25 tweets to get a feel for ORM usage with Android

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.

[cheesecow]

Round two on review for this project this is now updated for week 3 requirements @nesquena @timothy1ee

[nesquena]

Looks good overall Eric although a few things are missing and/or incomplete. Feedback below:

• Used FrameLayout to act as a container for timeline tab content
• Setup ActionBar Tabs mode with the Home and Mentions timeline tabs
  • Should checkout tabs cliffnotes to see how you might do this in a Gingerbread compatible way and using a "FragmentTabListener" which is recommended approach by Google.
• Setup the base fragment class that the timelines all extend from
• Setup home timeline fragment without code duplication
• Setup mentions timeline fragment without code duplication
• OPTIONAL: Should consider implementing endless pagination that works for all three timelines as a further learning opportunity
• Properly setup user profile view with profile header and a user timeline fragment
  • Can view my profile by clicking on the ActionBar
• Clicking on a users profile image takes me to their profile
  • Nice use of imageView tag to manage the user brought up
  • MISSING: No timeline actually shows up for friend users in their profile?
• OPTIONAL: Should play with ActiveAndroid in the future to get a feel for DB persistence
• BUG: When I compose a tweet, I don't see it in my home timeline

Nice work overall, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Today (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.