search

cheezy / page_navigation

Provides basic navigation through a collection of items that use the PageObject pattern.
MIT License
10 stars 7 forks source link

Why use DataMagic as the YML loader? #9

Open azohra opened 8 years ago

azohra commented 8 years ago

Hey @cheezy,

Would you be open to a PR which switches page_navigation to use FigNewton, or YMLReader directly. By using DataMagic we take on Faker as a dependency which adds unnecessary weight.

Best, Justin

azohra commented 8 years ago

If we can merge the symbol support PR to FigNewton, this would all come together nicely.

jeffnyman commented 8 years ago

While this topic is somewhat on people's mind, is there any example at all that shows how to use a YAML file with this page navigation functionality? I see a unit test for it but it makes little sense in terms of the usage. And most things I try seem not to work.

More specifically, how does this line actually do anything:

https://github.com/cheezy/page_navigation/blob/master/lib/page_navigation.rb#L123

DataMagic is loading a file -- but how is that information being preserved and then used?