chef-boneyard / chef-client

Development repository for Chef Client cookbook
http://supermarket.chef.io/cookbooks/chef-client
Apache License 2.0
175 stars 421 forks source link

Remove `file_staging_uses_destdir` default attribute value #703

Closed lamont-granquist closed 4 years ago

lamont-granquist commented 4 years ago

The default should be the existing chef-client default, this is super not appropriate for the general public. People need to override this specifically if they need it.

closes #702

this reverts #650, the cookbook does not need to set a default for users to be able to use it.

[ In general, this cookbook should NOT be setting default attribute values for everything in chef-config, since if it gets them wrong or we change the defaults depending on the chef-client major version then people will be getting the defaults that we do not intend. To do it right would require potentially gating defaults in this cookbook based on the chef-client version being used, along with validation added to testing that the defaults match up on every chef-client version. If that sounds wrong and not-DRY it is because it is wrong and not-DRY, so it should not be done. ]