Make the onbootsec parameter to attribute

vineethp088 commented 4 years ago

This is to make the OnBootSec parameter to control via attribute when the chef-client runs as a timer service,

Description

This is to make the OnBootSec parameter to control via attribute when the chef-client runs as a timer service. There are cases chef-client run after the boot is elapsed, becuase of the default 1min and there should be a mechanism to control this parameter. Changing this parameter to hgher value seems to be fixing this and should be control it via attribute, keeping 1 min as default.

Issues Resolved

There are cases chef-client run after the boot is elapsed, becuase of the default 1min and there should be a mechanism to control this parameter. Changing this parameter to higher value seems to be fixing this and should be control it via attribute, keeping 1 min as default.

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

dheerajd-msys commented 4 years ago

Issue https://github.com/chef-cookbooks/chef-client/issues/627 probably be fixed by this PR

phiggins commented 4 years ago

I think this change is a good idea, but I don't think this is the right way to do it and this is complicated by what looks like a bug from confusing behavior.

The properties delay_after_boot, interval, and splay are eventually used as systemd time spans.
delay_after_boot and interval accept arbitrary strings, so they can be a number of seconds eg '60' or it can include time units eg 5h30m.
splay is coerced to an integer so it is assumed to be a number of seconds.

Appending sec onto the value specified for delay_after_boot in recipes/systemd_service.rb could end up with incorrect values like '5h30msec. That also means the current behavior of interpolating interval is incorrect. Since bare values are interpreted as seconds, the code in the recipe should probably use the values directly:

      'OnBootSec' => node['chef_client']['delay_after_boot'],
      'OnUnitInactiveSec' => node['chef_client']['interval'],
      'RandomizedDelaySec' => node['chef_client']['splay'],

dheerajd-msys commented 3 years ago

@vineethp088 Could you please make changes per suggestion here ? then I guess we would be good to merge the PR.

Thanks

chef-boneyard / chef-client