search

chef-boneyard / chef-provisioning-aws

AWS driver and resources for Chef that uses the AWS SDK
Apache License 2.0
142 stars 121 forks source link

[MSYS-700] Migrate aws_cloudsearch_domain from v1 to v2 #549

Closed Vasu1105 closed 6 years ago

Vasu1105 commented 7 years ago

Note: @tyler-ball @btm Added deperication warning for cloudsearch_api_version attribute since there is no support for this in version 2 Ref http://docs.aws.amazon.com/sdkforruby/api/Aws/CloudSearch/Client.html

Signed-off-by: Vasu1105 vasundhara.jagdale@msystechnologies.com

NimishaS commented 7 years ago

Please note that this can be a breaking change since we have to remove cloudsearch_api_version attribute which was previously supported by V1 API, but isn't supported by V2 API.

thommay commented 7 years ago

Might be better to keep the attribute and just emit a deprecation warning if it's used (and throw away anything passed to it).

Vasu1105 commented 6 years ago

@NimishaS @thommay Done necessary changes for deprecation warning for cloudsearch_api_version attribute.