search

chef-boneyard / chef-provisioning-aws

AWS driver and resources for Chef that uses the AWS SDK
Apache License 2.0
142 stars 121 forks source link

Fix load balancer test failures #552

Closed tyler-ball closed 7 years ago

tyler-ball commented 7 years ago

@Vasu1105 I think this is ready for merge!

I reverted https://github.com/chef/chef-provisioning-aws/pull/552/commits/a464e484611228789c41b46bef441fe4c2760945 because that change effectively makes the . create_an_aws_load_balancer compare the exact same two values.

The first string passed to create_an_aws_load_balancer is used to lookup an aws_object based on the aws_object method. With the change you had, it was then comparing that object to another object looked up from AWS in the exact same way. So the expected and actual values were the same looked up object from AWS.

I fixed some of the comparison operator's failure to deal with Structs and I think this is ready for review now!

btm commented 7 years ago

@NimishaS @Vasu1105 I think we want/need to get this merged before final release. Can you take a look?

Vasu1105 commented 7 years ago

LGTM @btm

NimishaS commented 7 years ago

LGTM