fog:Rackspace uses servers#create, which only allows a key name

martinb3 commented 9 years ago

Hey! So I'm working on a PR that adds a Rax-specific example of this driver, and I've tripped over something. This driver uses servers#create which requires a named keypair already be created on the account.

Taking a survey of what other tools use to create nodes at Rackspace using fog, I found two different behaviors:

knife-rackspace uses passworded SSH with an optional ability to provide a key name, but you must create the key yourself (not unlike the requirement currently in chef-provisioning-fog)
kitchen-rackspace actually uses fog's other way to create Rackspace instances, servers#bootstrap, which actually uses SSH to get a public key on the server.

I also found that the fog Rackspace compute v1 provider had a similar bootstrap implementation.

It seems like the recommended 'fog best practice' way to bootstrap a Rackspace server using SSH keys is to use the bootstrap method, according to their docs. chef-provisioning-fog currently uses the create server method. I'm not sure this is an urgent fix, but I wanted to at least raise an issue so folks who try to do what I did are aware.

jjasghar commented 8 years ago

@martinb3 when you get some time in the near future mind syncing with me on this? I don't think this is still relevant, but I'd like to confirm.

martinb3 commented 8 years ago

Hey sure! I'm not sure which way is the right answer here, though. @mdarby do you have any thoughts about which is better?

mdarby commented 8 years ago

I don't honestly; I'd be concerned about breaking existing libs.

chef-boneyard / chef-provisioning-fog

fog:Rackspace uses servers#create, which only allows a key name #130