search

chef-boneyard / chef-provisioning-fog

Fog driver for Chef Provisioning
Apache License 2.0
54 stars 74 forks source link

Vcair changes #197

Closed monkey1016 closed 7 years ago

monkey1016 commented 8 years ago

I updated the vcair driver in the hopes of getting it working better with vCloud Director. I tried to make it similar to chef-provisioning-vra, but I understand that it changes how the vcair driver works compared to the other fog drivers.

I've switched it from using knife configuration options to use driver_options and made some changes to the driver url. If it doesn't mesh well, let me know. I'd appreciate the feedback.

If it looks good, I can provide documentation for the changes.

jjasghar commented 8 years ago

With our new policy please use the DCO signing process.

For a detailed description or you can just do:

$ git commit -s
$ #Or
$ git commit --signoff

If you already have the commit, use git commit --amend or git rebase -i to edit your commit message, and add the above signoff line.

Or if you want a more perminant option the following is a way to set it forever:

$ git config commit.gpgsign true
monkey1016 commented 8 years ago

Sorry about that. I signed the commit.

jjasghar commented 8 years ago

Looks good. I would like someone else to 👍 that uses vcair before merging/releasing.

As soon as that happens I'll update the gem.

jjasghar commented 7 years ago

@monkey1016 awesome, thanks for all this. I don't have the expertise in vcair to say if this works or not. If we can get someone to comment and say that it's good, i'm willing to release this.

Thanks for making chef-provisioning-fog more delightful!

monkey1016 commented 7 years ago

Looks like a change to the cheffish gem (v4.1.0) caused the tests to start failing for the Rackspace provider. I downgraded to cheffish v4.0.0 and everything started working again. See failing build vs working build

monkey1016 commented 7 years ago

Hi, Any chance we can merge this into the repo so we can get a released version of the gem? There don't seem to be many users of vCloud Director or vCloud Air. Or maybe fork to a separate gem if there's no intention on supporting vCloud? I suspect if we wait for a someone else to say it works, we'll be waiting for a long, long time.

jjasghar commented 7 years ago

thanks for all this work, i've gone ahead and released v0.22.0 of this gem. 🤘

monkey1016 commented 7 years ago

Awesome! Thanks. I'll create another pull request for some docs too. Been meaning to do that too.

jjasghar commented 7 years ago

Perfect! Thanks!