search

chef-boneyard / chef-provisioning

A library for creating machines and infrastructures idempotently in Chef.
Apache License 2.0
524 stars 164 forks source link

Add test coverage for overlapping methods and attributes machine_batch / chef_server / machine_options / image_options #429

Open tyler-ball opened 9 years ago

tyler-ball commented 9 years ago

In https://github.com/chef/chef-provisioning/blob/4638bdf99e048452b5b80e06c118ba2a0a0132a3/lib/chef/provisioning/chef_run_data.rb and https://github.com/chef/chef-provisioning/blob/4638bdf99e048452b5b80e06c118ba2a0a0132a3/lib/chef/provisioning/recipe_dsl.rb we provide helper methods to define globals which merge with certain attributes. Unfortunately, there is not sufficient testing or documentation on how this is supposed to work.

How do the attributes in the machine_batch get merged down to the individual machines? What about actions? How does CP automatically batch individual machines?

Related:

https://github.com/chef/chef-provisioning/issues/78 https://github.com/chef/chef-provisioning/issues/376 https://github.com/chef/chef-provisioning/issues/378 https://github.com/chef/chef-provisioning/issues/383 https://github.com/chef/chef-provisioning/issues/413 https://github.com/chef/chef-provisioning/issues/422 https://github.com/chef/chef-provisioning/issues/438 https://github.com/chef/chef-provisioning/issues/448 https://github.com/chef/chef-provisioning/issues/455 https://github.com/chef/chef-provisioning-aws/issues/306

This probably deserves its own EPIC

hh commented 8 years ago

Do we have an EPIC for this yet?

tyler-ball commented 8 years ago

@hh unfortunately not - we're working on non-provisioning stories for the foreseeable future

hh commented 8 years ago

I'm not sure what you mean by non-provisoning... non chef-provisoning?

tyler-ball commented 8 years ago

@hh Yes, non chef-provisioning work