The helper method `DeliverySugar::DSL.delivery_workspace` contains a `rescue` that triggers every time in Deploy phase of `delivery-truck`

[jerryaldrichiii]

There is a rescue here that always triggers in the Deploy phase. This causes errors in Deploy for instances where the default workspace path is not used (e.g Windows Build Nodes).

I believe the issue is caused by calling DeliverySugar::ChefServer.new.with_server_config from within DeliveryTruck::Helpers::Deploy without passing the node object. Which causes change to fail to initialize (and triggering the rescue)

Here is the code path that leads to the error (based on my understanding):

• DeliveryTruck::Helpers::DSL.delivery_chef_server_search is called
• DeliveryTruck::Helpers::Deploy method is called (no node object passed)
• DeliverySugar::ChefServer is initialized without arguments
• DeliverySugar::DSL.delivery_knife_rb is called
• DeliverySugar::DSL.delivery_workspace is called
• DeliverySugar::DSL.change is called
• change object fails to initialize because node does not exist
• rescue is triggered in DeliverySugar::DSL.delivery_workspace
• Run fails because knife.rb is not found

[jerryaldrichiii]

Closing issue and instead referencing in PR on delivery-truck