Hey!
I ran Cookstyle 6.7.3 against this repo and here are the results.
This repo was selected due to the topics of cookbook
Changes
Issues found and resolved with libraries/delivery_github_provider.rb
19:1 refactor: ChefModernize/IncludingMixinShelloutInResources - There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.
23:1 convention: Layout/EmptyLinesAroundClassBody - Extra empty line detected at class body beginning.
24:7 refactor: ChefModernize/IncludingMixinShelloutInResources - There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.
Issues found and resolved with libraries/delivery_supermarket.rb
23:3 warning: ChefDeprecations/ResourceUsesOnlyResourceName - Starting with Chef Infra Client 16, using resource_name without also using provides will result in resource failures. Use provides to change the name of the resource instead and omit resource_name entirely if it matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME.
Issues found and resolved with resources/delivery_terraform.rb
1:1 warning: ChefDeprecations/ResourceUsesOnlyResourceName - Starting with Chef Infra Client 16, using resource_name without also using provides will result in resource failures. Use provides to change the name of the resource instead and omit resource_name entirely if it matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME.
Hey! I ran Cookstyle 6.7.3 against this repo and here are the results. This repo was selected due to the topics of cookbook
Changes
Issues found and resolved with libraries/delivery_github_provider.rb
ChefModernize/IncludingMixinShelloutInResources- There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.Layout/EmptyLinesAroundClassBody- Extra empty line detected at class body beginning.ChefModernize/IncludingMixinShelloutInResources- There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.Issues found and resolved with libraries/delivery_supermarket.rb
ChefDeprecations/ResourceUsesOnlyResourceName- Starting with Chef Infra Client 16, usingresource_namewithout also usingprovideswill result in resource failures. Useprovidesto change the name of the resource instead and omitresource_nameentirely if it matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME.Issues found and resolved with resources/delivery_terraform.rb
ChefDeprecations/ResourceUsesOnlyResourceName- Starting with Chef Infra Client 16, usingresource_namewithout also usingprovideswill result in resource failures. Useprovidesto change the name of the resource instead and omitresource_nameentirely if it matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME.