Closed mjohno closed 9 years ago
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Hey @mjohno !! Thank you for your PR, we will review the use case and functionality and let you know our findings. But if everything looks good we will also merge it through our Pipeline.
+1 for supporting open source git servers for the publish phase. Thanks @mjohno!
@mjohno We are going to push your change but we need you to first sign the CLA here -> https://supermarket.chef.io/become-a-contributor
@afiune I believe I already have. mjohno is my username on Chef Supermarket.
@mjohno That is interesting.. I can see you here (https://supermarket.chef.io/users/mjohno) but the bot doesn't recognize you.. Anyway that validates it! :smile: I am going to start working on this to push it through our Delivery Server. I will keep you posted! Thanks!
nice work @mjohno !!! your first chef contribution :smiley:
@mvillis Indeed! Time to celebrate.. :smile:
I am going to submit a quick change on the code that you guys should be aware.. Take a look to this branch here, the change is only to standardize the name on the data bag item. Instead of git_key
lets try to use just git
... cc/ @mjohno
Thoughts?
@mjohno @mvillis Take a look here https://github.com/opscode-cookbooks/delivery-truck/commit/65faa78d908238440fddd0d6c49e31486f371cdb
@afiune looks good. Just do it and we can refactor our databags easy enough.
Added support for a generic "git" tag to be added to the .delivery/config.json file. The blob looks like this:
Only supports SSH.