search

chef-boneyard / delivery-truck

DEPRECATED: Delivery build cb for pipelines
Apache License 2.0
36 stars 52 forks source link

Support foodcritic fail tags and fix multiple only rules #19

Closed christinedraper closed 8 years ago

christinedraper commented 8 years ago

Currently lint phase only reports a problem if one of the correctness rules fires. This PR adds a fail_tags option to the config.json to make this configurable. For example, "fail_tags": ["any"] will report if any rule fails.

The PR also changes foodcritic_tags to generate a comma-separated list -t FC002,FC005 because foodcritic does not correctly handle multiple -t flags like -t FC002 -t FC005. Multiple ignore tags like -t ~FC008 -t ~FC009 works correctly.

Let me know if you need the two things as separate PRs

afiune commented 8 years ago

Change is in Review! screen shot 2016-05-11 at 1 59 20 pm

afiune commented 8 years ago

@christinedraper Could you just rebase to have a single commit? I think we are close to approve this! 👍

Ill wait for you to do that, you might need to force push... 😄

christinedraper commented 8 years ago

@afiune - should be good to go now

afiune commented 8 years ago

Pushing it to Delivery! 👍

afiune commented 8 years ago

Change was Demoed and Delivered!! 👍 Great work! Thank you @christinedraper

afiune commented 8 years ago

Merged! https://github.com/chef-cookbooks/delivery-truck/commit/37f2c0a03cfdba3b0a319e2def933c6a2c82ab05