search

chef-boneyard / minitest-chef-handler

Run minitest suites after your Chef recipes to check the status of your system.
Other
163 stars 44 forks source link

Test error doesn't fail convergence #29

Closed matschaffer closed 12 years ago

matschaffer commented 12 years ago

Failures cause my chef-solo run to exit on a non-zero just fine, but test errors (like exceptions) are considered a convergence success. Is this intentional? I'm running on the 0.6.0 release, btw. Thanks!

calavera commented 12 years ago

IIRC Chef doesn't consider an error the fact that a reporter fails. We can change that logic and add an exception in tests to raise an error when run completes as we do with test failures.

Feel free to open a pull request, this is where the magic happens:

https://github.com/calavera/minitest-chef-handler/blob/master/lib/minitest-chef-handler.rb#L35-46