search

chef-boneyard / minitest-chef-handler

Run minitest suites after your Chef recipes to check the status of your system.
Other
163 stars 44 forks source link

alias run to _run for Ruby 1.9.2 #4

Closed btm closed 12 years ago

btm commented 12 years ago

Workaround run method naming on Ruby 1.9.2 for MiniTest::Unit._run, closes #3

calavera commented 12 years ago

I'm sorry but I think this patch is not right. As I said in the ticket, that depends on the Minitest version but not in the ruby version. You can upgrade Minitest in your ruby 1.9.2 installation and this handler will work as expected.

btm commented 12 years ago

Except that MiniTest::Unit is in Ruby 1.9. I get the same error under Ruby 1.9.2p318 if I have the minitest gem version 2.12.0 (latest) installed as I do with no minitest gem installed at all.

btm commented 12 years ago

Alternately if you wanted to prefer the gem you could add:

require 'rubygems'
gem 'minitest'

To the top of minitest-chef-handler.rb. This would then make rubygems a requirement. I've tested this solution working on Ruby 1.9.2-p318 with minitest 2.12.0.

calavera commented 12 years ago

I've released a new version that solves this problem for users that have old versions of minitest installed.

Thanks for the report and the patch.